Changelog 2016-03-14

Comments

• Dissi March 14, 2016 09:06

  Nice changes, I like them.

  Could we introduce new things to PTR next time? the new cooldown broke my chemestry setup (easy fix, but annoying)

• 
  Artem from Screeps March 14, 2016 09:52

  How did it break your code? This is not a breaking change of any kind. You can call `runReaction` every tick as before and everything will run as usual.

• Dissi March 14, 2016 09:57

  Well not exactly break, but I stored the exact amount of reactions it needed in memory, with the cooldown it tried to perform the reaction anyway, I did not check if the result was OK.

   

  The counter of the amount of reactions to run got diminished anyway, but the supplier labs were not empty yet when my code thought it was finished reacting.

  Later when the chemist-creep started filling it up, it still had some minerals inside the supplier labs, causing an error for when transferring.

   

   

  Code in question:

  for(var lab = 0 ; lab < result.length; lab++)
   {
   if(theRoom.memory.chemLab.rCount == 0)
   {
   log("Max amount of reactions consumed for room " + theRoom.name,"chemistry");
   theRoom.memory.chemLab.stage = CONST_CHEM_STATE_COLLECT_PRODUCE;
   return;
   }
   theRoom.memory.chemLab.rCount--;
   result[lab].runReaction(theLabs[0], theLabs[1]);
   }

   

   

  Fix was:

   

  for(var lab = 0 ; lab < result.length; lab++)
  {
     if(result[lab].cooldown != 0)
     {
          continue;
     }
    if(theRoom.memory.chemLab.rCount == 0) {
    log("Max amount of reactions consumed for room " + theRoom.name,"chemistry");
    theRoom.memory.chemLab.stage = CONST_CHEM_STATE_COLLECT_PRODUCE;
   return;
  }
   theRoom.memory.chemLab.rCount--;
   result[lab].runReaction(theLabs[0], theLabs[1]);
  }

   

   

   

   

  Edited by Dissi March 14, 2016 10:01
• 
  Artem from Screeps March 14, 2016 10:00

  You should not rely on scheduling commands this way. Even when you get OK code it doesn't mean that the scheduled action will take place due to parallel actions processing architecture.

• Dissi March 14, 2016 10:02

  It was still experimental code to get a feeling for the chemistry, I'm now checking if the supplier labs are empty